Open
Conversation
added 3 commits
January 30, 2019 16:04
This patch avoid resorting the directory tree after the sync. Instead, it sorts the new items pulled during the sync and merges them into the new tree without sorting both lists again.
This changes the function that converts the rsync listing to the tree state files. In my tests, it reduces the time on a list of 250k files from 12 seconds down to 7.
This significantly reduces the processor load in stripping the leading 12 chars from the tree state files. On my test file of 250k files, time is reduced from 960ms to 140ms. Since the `strip_mode` function is used four times on a normal run, this change saves 3s or processor time from my test files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overall, this results in about a 20% reduction in the CPU time of the
analyzephase of the sync.