Improve Makefile documentation and add caching for notebooks repository#150
Merged
juliusvonkohout merged 3 commits intokserve:masterfrom Feb 4, 2026
Merged
Conversation
- Use shorter commit hash (7 chars) in frontend/COMMIT for consistency - Add consistent annotations across all Makefiles about kubeflow/notebooks repo - Add intelligent caching to frontend Makefile setup: * Skip git fetch/checkout if already at target commit * Skip library rebuild if already built * Skip npm install if dependencies exist * Skip symlink recreation if already correct * Skip asset copying if already present - Add automatic CSS and assets copying during setup - Add fallback for short hash resolution with git rev-parse Resolves issues with fresh setup and improves developer experience with faster repeated setup runs. Signed-off-by: Harshit Nayan <[email protected]>
Signed-off-by: Harshit Nayan <[email protected]>
Signed-off-by: Julius von Kohout <[email protected]>
juliusvonkohout
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issues with fresh setup and improves developer experience with faster repeated setup runs.