Skip to content
This repository was archived by the owner on Apr 14, 2026. It is now read-only.

feat: ensure maven 3.9 - #169

Merged
terrytangyuan merged 1 commit into
kserve:mainfrom
spolti:updateMaven
Mar 9, 2026
Merged

feat: ensure maven 3.9#169
terrytangyuan merged 1 commit into
kserve:mainfrom
spolti:updateMaven

Conversation

@spolti

@spolti spolti commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Motivation

Modifications

Result

@spolti
spolti requested review from Jooho and terrytangyuan March 5, 2026 18:04
Comment thread Dockerfile Outdated
Comment on lines +42 to +43
microdnf -y module reset maven \
&& microdnf -y module enable maven:3.9 \

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terrytangyuan terrytangyuan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the PR description and address the comment from Adam?

@spolti
spolti force-pushed the updateMaven branch 2 times, most recently from 93297dc to a8f2207 Compare March 5, 2026 19:40
@spolti

spolti commented Mar 5, 2026

Copy link
Copy Markdown
Contributor Author

For now, I think it is better to stay with UBI9, while trying UBI10 a few issues were found, including:

The Maven's ASM dependency is unbundled and missing

RHEL 10's sisu RPM (used by Maven for dependency injection) unbundles objectweb-asm, but the objectweb-asm RPM is not available in any UBI 10 repo (base, appstream, or CRB).
Symptom:

NoClassDefFoundError: org/objectweb/asm/ClassVisitor                                                                                                                                                                            

So Maven fails to inject any plugin compiled with Java 17+ bytecode (e.g., protobuf-maven-plugin v5.0.0).

Root cause: The package exists in CentOS Stream 10 AppStream (objectweb-asm-9.6-6.el10.noarch) but is not shipped in the UBI subset.

This is effectively a packaging bug — Maven is broken out of the box on UBI 10 for any plugin requiring bytecode scanning.

Signed-off-by: Spolti <fspolti@redhat.com>
@adambkaplan

Copy link
Copy Markdown

This is effectively a packaging bug — Maven is broken out of the box on UBI 10 for any plugin requiring bytecode scanning.

Submitted this to RHEL for further investigation: https://issues.redhat.com/browse/RHEL-154034

@spolti

spolti commented Mar 9, 2026

Copy link
Copy Markdown
Contributor Author

@adambkaplan @terrytangyuan can we go with ubi9 for now?

@terrytangyuan

Copy link
Copy Markdown
Member

Yes

@terrytangyuan
terrytangyuan merged commit 0604dff into kserve:main Mar 9, 2026
8 checks passed
@spolti
spolti deleted the updateMaven branch March 9, 2026 20:36
@mkoncek

mkoncek commented Mar 19, 2026

Copy link
Copy Markdown

The Maven's ASM dependency is unbundled and missing

It is bundled but the bytecode-version-handling code not been kept up-to-date.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants