BUGFIX: Correct position checking logic in details element#128
Open
iainh wants to merge 1 commit intokristoff-it:mainfrom
Open
BUGFIX: Correct position checking logic in details element#128iainh wants to merge 1 commit intokristoff-it:mainfrom
iainh wants to merge 1 commit intokristoff-it:mainfrom
Conversation
The original code compared `child_idx != parent.first_child_idx` which didn't account for skipped text/comment nodes. For example, prior to this change the summary element in the following code was considered in the wrong position: <details> <!-- Comment --> <summary></summary> </details> After changing to track flow elements instead it is valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original code compared
child_idx != parent.first_child_idxwhich didn't account for skipped text/comment nodes.For example, prior to this change the summary element in the following code was considered in the wrong position:
After changing to track flow elements instead it is valid.