Make tool calls universal (work under e.g. Nix/NixOS)#9
Open
candeira wants to merge 1 commit intokraken-tech:mainfrom
Open
Make tool calls universal (work under e.g. Nix/NixOS)#9candeira wants to merge 1 commit intokraken-tech:mainfrom
candeira wants to merge 1 commit intokraken-tech:mainfrom
Conversation
Collaborator
|
@candeira can you sign your commits and push back up please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tools in
tools/have a hard-coded hashbang bash path that may work under MacOS and some linuces, but breaks in other systems like NixOS.Changing the hashbang paths to
/usr/bin/env bashworks under more systems, including the ones it already worked under before.