Loosely type experiment objects#6
Draft
edenbtw wants to merge 1 commit intoexperiments.remove-experiment-initialisation-by-decoratorfrom
Draft
Loosely type experiment objects#6edenbtw wants to merge 1 commit intoexperiments.remove-experiment-initialisation-by-decoratorfrom
edenbtw wants to merge 1 commit intoexperiments.remove-experiment-initialisation-by-decoratorfrom
Conversation
edenbtw
changed the base branch from
master
to
experiments.remove-experiment-initialisation-by-decorator
freya-mankelow-kraken
approved these changes
Dec 12, 2025
freya-mankelow-kraken
left a comment
freya-mankelow-kraken
left a comment
There was a problem hiding this comment.
Good start on the typehinting! 🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of these initial type hints is just to get MyPy running. The core package was written very dynamically and refactors will be needed to enable stronger type checking.