Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this does work... I'm partly concerned that it could maybe be slightly taxing on the software renderer?
The PrBoom renderer is annoying because when it comes to drawing the player's weapons, it can sometimes bleed outside of the bounds, due to how it stretches sprites. This clamps it so that it never "wraps around".
This was extremely relevant in some resolutions, where when the SSG was fired on it's lowest point, the top of the SSG firing sprite would "wrap around" to the bottom of the sprite creating a red/orangish line as seen here:
My resolution of testing was 2560x1440, where this could happen consistently. It's much more noticeable when running the Minor Sprite Fix which fixes the SSG firing animation (Nyan includes this automatically).
Related is a PrBoom PR coelckers/prboom-plus#181 and issue coelckers/prboom-plus#95 that tried to fix the opposite with the bleeding on the top of the weapon. Maybe there's a way to simplify these fixes?