Open
Conversation
- Open in same window - Draw ENDOOM using OpenGL - Allow terminal vs window ENDOOM - Includes Zokum's new font
- since we are avoiding the ENDOOM for demos, this seems reasonable. - "smart" is also preferred since it is guaranteed to show for pwads with custom art.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's finally here!
This replaces PR #599 .
This is my implementation of ENDOOM for Nyan. It is based off the simpler code from Woof, but with the added support of drawing ENDOOM via OpenGL. Drawing using OpenGL was required in order to draw the ENDOOM in the same window.
I've made the decision to disable the ENDOOM entirely when recording / playing back demos, as most speedrunners don't care to see that when making attempts.
There are now 3 config options for ENDOOM (just 1 in the menu):
show_endoom- This is the menu option, and has 3 options (off, on, smart). Smart is very similar to pwad-only, but allows for the ENDOOM to show for IWADs, if no pwad map lumps are found. I've set the default for this to 2 (smart), as due to the change for disabling ENDOOM for demos, I think it's better to show off artist's ENDOOM art, rather than keep it hidden for casual play.export_endoom- This option when set totrue, will show the old terminal based ENDOOM. I called it "export" because it's essentially exporting the ENDOOM data to the terminal... Maybe there's a better name?ansi_endoom- This option previously allowed enabling/disabling the ENDOOM, while also customising the ansi type. Can we stop trying to tie multiple functionalities to one config :/ This option now only controls the ansi type, and has no bearing on enabling the ENDOOM. Setting this option to 0 will now default to 1 (format_cp437).A little minor note about the "smart" option... Currently because the PR #837 hasn't been integrated, it doesn't take autoload into account. In Nyan Doom, this is corrected to use
W_PWADLumpNumExists2().