Print date and time in the Load/Save Game menus in the current locale#847
Open
fabiangreffrath wants to merge 2 commits intomasterfrom
Open
Print date and time in the Load/Save Game menus in the current locale#847fabiangreffrath wants to merge 2 commits intomasterfrom
fabiangreffrath wants to merge 2 commits intomasterfrom
Conversation
Collaborator
|
Right I had fixed this a few months ago but never did a PR, thanks! In locales where the year is not abbreviated to 2 numbers, we need to increase |
Collaborator
Author
This will immediately introduce an incompatiblity with any older savegame. |
Collaborator
Author
|
We could drop seconds: --- a/prboom2/src/m_menu.c
+++ b/prboom2/src/m_menu.c
@@ -1482,7 +1482,7 @@ static void M_QuickSave(void)
time (&now);
timeinfo = localtime (&now);
- strftime(description, sizeof(description), "quick %x %X", timeinfo);
+ strftime(description, sizeof(description), "quick %x %H:%M", timeinfo);
G_SaveGame(QUICKSAVESLOT, description);
doom_printf("%s", description); |
Collaborator
Author
|
Or we abbreviate the "quick" string with e.g. a mere "q"? |
Collaborator
Collaborator
Author
|
Strictly speaking, we don't even need neither "QUICK" nor "Q" at all. We have an entire savegame page called "Q" just for these. |
Collaborator
|
True 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #818