Skip to content

Fixes autoloaded HELP lumps being treated as missing#836

Closed
Adrad1234 wants to merge 1 commit intokraflab:masterfrom
Adrad1234:lump-load-fix
Closed

Fixes autoloaded HELP lumps being treated as missing#836
Adrad1234 wants to merge 1 commit intokraflab:masterfrom
Adrad1234:lump-load-fix

Conversation

@Adrad1234
Copy link
Contributor

Autoloading a WAD that replaces HELP and/or CREDIT lump, causes those lumps not to appear while while pressing F1, instead defaulting to dsda-doom credits.

@Pedro-Beirao
Copy link
Collaborator

This looks good, but @andrikpowell worked on the HELP/CREDIT loop, so can you review it?

@andrikpowell
Copy link
Contributor

This looks good, but @andrikpowell worked on the HELP/CREDIT loop, so can you review it?

I recently actually tweaked how I deal with this in Nyan, by adding a W_PWADLumpNumExists2() which includes pwad and autoload:
andrikpowell@b3b7fe2

Although, I think the function could be named better. I think it's worth differentiating between "pwad" and "pwad or autoload" for certain situations.

@andrikpowell
Copy link
Contributor

andrikpowell commented Jan 28, 2026

Ohhhh yeah... hmmm this is tricky...

The problem is, I don't want HELP or CREDIT to be included in autoload... However this is due to my personal setup... basically by default, in my iwad autoload folders, I have widescreen versions of the default IWAD assets (Doom, Doom 2, TNT, Plutonia, Heretic, Hexen, etc).

And I guess the issue is that since that's always in my autoload, the condition of showing the dynamic credits would just never happen in this case.

However from the logic of autoloading for a PWAD, you'd probably want to include the HELP / CREDIT from autoload for that...

I think that's the main problem with the current autoload system is that there's no way to determine iwad vs pwad autoload.

@andrikpowell andrikpowell mentioned this pull request Jan 28, 2026
@Pedro-Beirao
Copy link
Collaborator

Yeah this is why I wanted to get your opinion. I could imagine not wanting autoload to affect this is in some cases.

@Adrad1234 Adrad1234 closed this Jan 28, 2026
@Adrad1234 Adrad1234 deleted the lump-load-fix branch January 29, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants