Skip to content

Remove pointeless carraige return#814

Open
elf-alchemist wants to merge 1 commit intokraflab:masterfrom
elf-alchemist:pointless_cr
Open

Remove pointeless carraige return#814
elf-alchemist wants to merge 1 commit intokraflab:masterfrom
elf-alchemist:pointless_cr

Conversation

@elf-alchemist
Copy link
Copy Markdown
Contributor

No description provided.

@rfomin
Copy link
Copy Markdown
Collaborator

rfomin commented Nov 30, 2025

It's pointless on Linux, but not on Windows.

@elf-alchemist
Copy link
Copy Markdown
Contributor Author

elf-alchemist commented Nov 30, 2025

This is the singular instance of a text print using \r\n in the entire DSDA codebase, literally everywhere else is already using just a \n. I was wondering why my levelstat.txt diffs were not working between DSDA and Woof, and this was the sole exclusive reason :V

Windows has never had any issues in any situation handling just a single \n in my experience. This is a problem solely on DSDA's end :v

It very much is pointless.

@rfomin
Copy link
Copy Markdown
Collaborator

rfomin commented Nov 30, 2025

I was wondering why my levelstat.txt diffs were not working between DSDA and Woof, and this was the sole exclusive reason :V

Woof has a much simpler levelstat printing function; there are more differences than just the \r. The standard diff -w (ignores whitespace) should work; that's what we use in the woof/demotest script.

I don't think we should change this, it may break the parsing in people's tools.

@Pedro-Beirao
Copy link
Copy Markdown
Collaborator

I would like this changed, but breaking people's tools is a valid concern.
Maybe directly warning ZM and 4shock and mentioning this in the next changelog is enough

@andrey-budko
Copy link
Copy Markdown
Contributor

Windows has never had any issues in any situation handling just a single \n in my experience. This is a problem solely on DSDA's end :v

Only since 2018
https://devblogs.microsoft.com/commandline/extended-eol-in-notepad/

@Pedro-Beirao
Copy link
Copy Markdown
Collaborator

ZM and 4shock confirmed that this change wont affect their scripts, but no point in merging this anyway right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants