Conversation
On Linux/macOS `long` is 64 bit, on Windows 32 bit
Pedro-Beirao
left a comment
There was a problem hiding this comment.
Looks good thanks!
Its weird that it complains about P_ReplaceMobjWithIndex, but whatever.
The actual problem is the Kraflab removed the padding in the old Doom code. See: https://github.com/coelckers/prboom-plus/blob/969515162c5aebea4ad7a125ee178dcad3d576ad/prboom2/src/p_saveg.c#L53 How important is misalignment? I remember at least one crash related to this issue in Woof on Linux. There are a lot of changes in this PR, so more testing is needed. |
There are only
"left shift of negative value"errors left, which may not be worth fixing.