feat: error handling for http

[emirot]

Signed-off-by: emirot [email protected]

What

Add error handling when getting http value files.

Why

Fails silently and renders without interpolating or notifying.

Tests

Didn't find test files, so I tested manually.

docker build -t helmtest  --build-arg BUILDER_IMAGE=golang:1.18-alpine3.15    --build-arg  BASE_IMAGE=alpine:3.15 .

Then

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization


secretGenerator:
  - name: mysecret
    files:
      - username
      - password
    options:
      disableNameSuffixHash: true
      annotations:
        config.kubernetes.io/local-config: "true"

transformers:
  - |-
    apiVersion: fn.kpt.dev/v1alpha1
    kind: RenderHelmChart
    metadata:
      name: demo
      annotations:
        config.kubernetes.io/function: |
          container:
            network: true
            image: helmtest
    helmCharts:
    - chartArgs:
        name: mychart
        version: v2.4
        registry: myregistry
        auth:
          kind: Secret
          name: mysecret
      templateOptions:
        namespace: argocd
        releaseName: argocd
        values:
          valuesFiles:
            - https://gist.github.com/emirot/1234567

Testing

kustomize build --enable-alpha-plugins --network . 
failed to evaluate function: failed to run function: failed to run generator: non-ok http status: 404 returnedError: couldn't execute function: exit status 1 

[yuwenma]

The change looks good and thanks for the contribution again, @emirot! Just curious, why do you use the custom transformer rather than the kustomize builtin helmcharts?

[yuwenma]

CC @natasha41575

[emirot]

The change looks good and thanks for the contribution again, @emirot! Just curious, why do you use the custom transformer rather than the kustomize builtin helmcharts?

@yuwenma
Is that what you mean by kustomize builtin helmcharts ?
From my understanding currently Kustomize do not support helm inflate with private repositories , kubernetes-sigs/kustomize#4335 and won't be developed as said in the long term support. By having this it will bring us more flexibility as we could have any functions we want.

[yuwenma]

The change looks good and thanks for the contribution again, @emirot! Just curious, why do you use the custom transformer rather than the kustomize builtin helmcharts?

@yuwenma Is that what you mean by kustomize builtin helmcharts ? From my understanding currently Kustomize do not support helm inflate with private repositories , kubernetes-sigs/kustomize#4335 and won't be developed as said in the long term support. By having this it will bring us more flexibility as we could have any functions we want.

Gotcha, thanks for the reply.