Skip to content

setup.py: make version comply with PEP-440 #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crosser wants to merge 1 commit into
base: master
Choose a base branch
from
Open

setup.py: make version comply with PEP-440 #600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@ def get_version():
"""
try:
p = Popen(['git', 'describe', '--tags', '--match', 'v*'], stdout=PIPE)
version = p.communicate()[0].strip("\n\r \t")
version = p.communicate()[0].decode("ascii").strip("\n\r \t")
if p.returncode != 0:
raise Exception("git-describe failed")
version = version.split("-")[0].lstrip("v") # Comply with PEP-440
return version
except: pass
# Git-describe method failed, try to guess from working directory name
Expand All @@ -30,6 +31,7 @@ def get_version():
version = "v%s" % (version,)
break
path = path[0:-1]
version = version.split("+")[0].lstrip("v") # Comply with PEP-440
return version

class BuildPyEx(build_py):
Expand Down