Skip to content

🐛 Fix version of ilspycmd due to failure during build - #103

Merged
shawn-hurley merged 1 commit into
konveyor:mainfrom
jmle:bugfix/fix-ilspycmd
Apr 8, 2026
Merged

🐛 Fix version of ilspycmd due to failure during build#103
shawn-hurley merged 1 commit into
konveyor:mainfrom
jmle:bugfix/fix-ilspycmd

Conversation

@jmle

@jmle jmle commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
@jmle
jmle requested review from mguetta1 and shawn-hurley April 7, 2026 12:37
@coderabbitai

coderabbitai Bot commented Apr 7, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Two Dockerfile configurations have been updated to install the ilspycmd .NET global tool with an explicit version constraint (9.1.0.7988) instead of allowing installation of the latest available version. The changes appear in both Dockerfile and Dockerfile.test, with identical version specifications applied to each file. All other build steps and configurations remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Version pinned with care so fine,
ilspycmd locked at 9.1.0.7988's line,
No more surprises from updates on high,
Consistency hops—our Docker builds fly! 🚀

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess whether any explanation or context about the change was documented. Add a description explaining why version 9.1.0.7988 was chosen and what build failure this resolves.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: pinning ilspycmd to a specific version to resolve a build failure, which matches the Dockerfile and Dockerfile.test modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@Dockerfile`:
- Around line 19-20: Adjacent Dockerfile RUN steps installing Paket and ilspycmd
create extra image layers; combine them into a single RUN to satisfy DL3059 by
chaining the installs with && so both dotnet tool install commands (Paket and
ilspycmd --version 9.1.0.7988) run in one layer, preserving the same behavior
and exit semantics; update the Dockerfile RUN that currently installs Paket and
the subsequent RUN that installs ilspycmd into a single RUN that executes both
commands sequentially.

In `@Dockerfile.test`:
- Around line 21-22: Two consecutive Docker RUN instructions install global
dotnet tools (the lines running "dotnet tool install --global Paket" and "dotnet
tool install --global ilspycmd --version 9.1.0.7988"); merge them into a single
RUN to reduce image layers by chaining the installs with && (e.g., combine the
two install commands into one RUN using && and ensure any required environment
setup or PATH export remains correct after the combined command).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: d4a2d533-8f6a-4d25-a684-699c3f2a6dae

📥 Commits

Reviewing files that changed from the base of the PR and between 57af5b3 and f9606d9.

📒 Files selected for processing (2)
  • Dockerfile
  • Dockerfile.test

Comment thread Dockerfile
Comment on lines 19 to +20
RUN dotnet tool install --tool-path=/usr/local/bin Paket
RUN dotnet tool install --tool-path=/usr/local/bin ilspycmd
RUN dotnet tool install --tool-path=/usr/local/bin ilspycmd --version 9.1.0.7988

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Consider consolidating adjacent RUN steps to reduce image layers.

Hadolint DL3059 is valid here; combining Lines 19-20 keeps behavior the same while trimming layers.

Suggested Dockerfile diff
-RUN dotnet tool install --tool-path=/usr/local/bin Paket
-RUN dotnet tool install --tool-path=/usr/local/bin ilspycmd --version 9.1.0.7988
+RUN dotnet tool install --tool-path=/usr/local/bin Paket && \
+    dotnet tool install --tool-path=/usr/local/bin ilspycmd --version 9.1.0.7988
🧰 Tools
🪛 Hadolint (2.14.0)

[info] 20-20: Multiple consecutive RUN instructions. Consider consolidation.

(DL3059)

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@Dockerfile` around lines 19 - 20, Adjacent Dockerfile RUN steps installing
Paket and ilspycmd create extra image layers; combine them into a single RUN to
satisfy DL3059 by chaining the installs with && so both dotnet tool install
commands (Paket and ilspycmd --version 9.1.0.7988) run in one layer, preserving
the same behavior and exit semantics; update the Dockerfile RUN that currently
installs Paket and the subsequent RUN that installs ilspycmd into a single RUN
that executes both commands sequentially.

Comment thread Dockerfile.test
Comment on lines 21 to +22
RUN dotnet tool install --global Paket
RUN dotnet tool install --global ilspycmd
RUN dotnet tool install --global ilspycmd --version 9.1.0.7988

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Optional: merge consecutive tool-install RUN instructions.

This is a safe DL3059 cleanup and slightly reduces layer count.

Suggested Dockerfile.test diff
-RUN dotnet tool install --global Paket
-RUN dotnet tool install --global ilspycmd --version 9.1.0.7988
+RUN dotnet tool install --global Paket && \
+    dotnet tool install --global ilspycmd --version 9.1.0.7988
🧰 Tools
🪛 Hadolint (2.14.0)

[info] 21-21: Multiple consecutive RUN instructions. Consider consolidation.

(DL3059)


[info] 22-22: Multiple consecutive RUN instructions. Consider consolidation.

(DL3059)

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@Dockerfile.test` around lines 21 - 22, Two consecutive Docker RUN
instructions install global dotnet tools (the lines running "dotnet tool install
--global Paket" and "dotnet tool install --global ilspycmd --version
9.1.0.7988"); merge them into a single RUN to reduce image layers by chaining
the installs with && (e.g., combine the two install commands into one RUN using
&& and ensure any required environment setup or PATH export remains correct
after the combined command).

@jmle
jmle enabled auto-merge (squash) April 7, 2026 13:40
@jmle
jmle disabled auto-merge April 7, 2026 13:41
@shawn-hurley
shawn-hurley enabled auto-merge (squash) April 8, 2026 17:55
@shawn-hurley
shawn-hurley disabled auto-merge April 8, 2026 18:42
@shawn-hurley
shawn-hurley merged commit 1739a33 into konveyor:main Apr 8, 2026
11 of 15 checks passed
shawn-hurley pushed a commit to konveyor/analyzer-lsp that referenced this pull request Apr 9, 2026
Trying to fix problems when maven is copying an artifact to a volume.
Needed for
konveyor/c-sharp-analyzer-provider#103

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Chores**
* Updated automated testing workflows to ensure proper test environment
configuration and improve test execution reliability.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
eemcmullan pushed a commit to eemcmullan/c-sharp-analyzer-provider that referenced this pull request Apr 10, 2026
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
eemcmullan added a commit that referenced this pull request Apr 10, 2026
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Co-authored-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants