Добавлены файлы с заданиями по проекту 5ого спринта#1
Open
komorebi-ps wants to merge 1 commit intomainfrom
Open
Добавлены файлы с заданиями по проекту 5ого спринта#1komorebi-ps wants to merge 1 commit intomainfrom
komorebi-ps wants to merge 1 commit intomainfrom
Conversation
AlexKitIt
reviewed
Jan 12, 2026
| browser.find_element(*MainPageLocators.USERPIC).click() | ||
| WebDriverWait(browser, 10).until(expected_conditions.visibility_of_element_located(ProfileLocators.MY_ADS)) | ||
|
|
||
| assert browser.find_element(*CreateAdLocators.NAME_OF_LAST_CARD_MY_ADS) == 'Новое объявление тест' |
There was a problem hiding this comment.
Можно лучше: тестовые данные стоит хранить отдельно в data модуле, так поддерживать и переиспользовать будет проще, в тестах и тестовых классах их держать не стоит
AlexKitIt
reviewed
Jan 12, 2026
| def test_create_ad(self, browser): | ||
|
|
||
| #авторизация | ||
| browser.get('https://qa-desk.stand.praktikum-services.ru/') |
There was a problem hiding this comment.
Можно лучше: урлы стоит хранить отдельно, они постоянно переиспользуются, для них стоит создать модуль urls или отдельный класс в data либо модуль urls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.