Merged
Conversation
| on: | ||
| push: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
Push trigger restricted beyond stated PR intent
Low Severity
The PR title states "also run test suite on PRs" implying an additive change, but the branches: - main restriction under push: changes existing behavior. Previously, tests ran on all pushes to any branch; now they only run on pushes to main. Developers pushing to feature branches without an open PR will no longer see test results, which may be unintended given the PR's stated scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Ensures CI test workflow runs for both PRs and main branch updates.
.github/workflows/test.ymltriggers to includepushonmainandpull_requestWritten by Cursor Bugbot for commit 5c4714a. This will update automatically on new commits. Configure here.