Skip to content

chore(CI): also run test suite on PRs#22

Merged
niklashigi merged 1 commit intomainfrom
chore/ci/tests-on-prs
Jan 7, 2026
Merged

chore(CI): also run test suite on PRs#22
niklashigi merged 1 commit intomainfrom
chore/ci/tests-on-prs

Conversation

@niklashigi
Copy link
Member

@niklashigi niklashigi commented Jan 7, 2026

Note

Ensures CI test workflow runs for both PRs and main branch updates.

  • Updates .github/workflows/test.yml triggers to include push on main and pull_request

Written by Cursor Bugbot for commit 5c4714a. This will update automatically on new commits. Configure here.

@niklashigi niklashigi merged commit cedd682 into main Jan 7, 2026
2 checks passed
@niklashigi niklashigi deleted the chore/ci/tests-on-prs branch January 7, 2026 17:54
on:
push:
branches:
- main
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Push trigger restricted beyond stated PR intent

Low Severity

The PR title states "also run test suite on PRs" implying an additive change, but the branches: - main restriction under push: changes existing behavior. Previously, tests ran on all pushes to any branch; now they only run on pushes to main. Developers pushing to feature branches without an open PR will no longer see test results, which may be unintended given the PR's stated scope.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant