Fix dep install fail on RHEL/CentOS-family distros - #897
Open
jordalgo wants to merge 1 commit into
Open
Conversation
This addresses two bugs: 1. Wrong group name for non-Fedora dnf distros. install_dependencies runs dnf_groupinstall "c-development", but c-development is a Fedora-only group. On RHEL/CentOS/Rocky/Alma the equivalent is "Development Tools". 2. Group failure is fatal but redundant. dnf_groupinstall calls stop on failure, aborting the whole install — even though the very next line, `dnf_install $deps`, installs the actual required packages explicitly. The group is only a convenience bundle and should never be fatal. Updates: - dnf_groupinstall is now best-effort with fallback names. Accepts multiple candidate group names, tries each, and continues (with an info message) if none match — instead of aborting. - Widen distro detection to match rhel|centos|rocky|alma|fedora Tested on my local CentOS machine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses two bugs:
Wrong group name for non-Fedora dnf distros. install_dependencies runs dnf_groupinstall "c-development", but c-development is a Fedora-only group. On RHEL/CentOS/Rocky/Alma the equivalent is "Development Tools".
Group failure is fatal but redundant. dnf_groupinstall calls stop on failure, aborting the whole install — even though the very next line,
dnf_install $deps, installs the actual required packages explicitly. The group is only a convenience bundle and should never be fatal.Updates:
Tested on my local CentOS machine.