Open
Conversation
…ontext of the connection point owner
protogenes
force-pushed
the
bugfix/event-unadvise
branch
from
c1fe833 to
68e70b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unadvising COM events needs to be done in the context of the owning COM object just as advising them needs to.
Therefor closing an EventProxy has to perform the actual unadvise task within the COMThread of the Wrapper for which advise() was used.
The fix forwards the proper COMThread during EventProxy creation and executes the unadvise task with its help.