Skip to content

hack: remove deprecated GO111MODULE=on#16499

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
Ankitsinghsisodya:fix/remove-go111module
Apr 1, 2026
Merged

hack: remove deprecated GO111MODULE=on#16499
knative-prow[bot] merged 1 commit intoknative:mainfrom
Ankitsinghsisodya:fix/remove-go111module

Conversation

@Ankitsinghsisodya
Copy link
Copy Markdown
Contributor

Fixes #16498

Changes

Remove the export GO111MODULE=on line from hack/update-checksums.sh and hack/update-reference-docs.sh.

GO111MODULE has been a no-op since Go 1.16 and is deprecated in Go 1.25. All other hack/ scripts already omit it.

GO111MODULE has been a no-op since Go 1.16 and is deprecated in Go 1.25.
Modules are enabled by default; the explicit export can be safely removed.
Copilot AI review requested due to automatic review settings April 1, 2026 10:05
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Apr 1, 2026

Welcome @Ankitsinghsisodya! It looks like this is your first PR to knative/serving 🎉

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 1, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Apr 1, 2026

Hi @Ankitsinghsisodya. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot requested review from dprotaso, dsimansk and skonto April 1, 2026 10:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the deprecated GO111MODULE=on environment export from the remaining hack/ scripts that still set it, aligning them with the rest of the repo and avoiding deprecated/no-op configuration on modern Go.

Changes:

  • Remove export GO111MODULE=on from hack/update-checksums.sh.
  • Remove export GO111MODULE=on from hack/update-reference-docs.sh.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
hack/update-reference-docs.sh Drops deprecated GO111MODULE export before running reference-doc generation.
hack/update-checksums.sh Drops deprecated GO111MODULE export before running checksum generation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dprotaso
Copy link
Copy Markdown
Member

dprotaso commented Apr 1, 2026

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Apr 1, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ankitsinghsisodya, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2026
@dprotaso
Copy link
Copy Markdown
Member

dprotaso commented Apr 1, 2026

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 1, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.18%. Comparing base (35cd19d) to head (ae4828a).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16499      +/-   ##
==========================================
- Coverage   80.26%   80.18%   -0.08%     
==========================================
  Files         217      217              
  Lines       13547    13547              
==========================================
- Hits        10873    10863      -10     
- Misses       2309     2318       +9     
- Partials      365      366       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knative-prow knative-prow bot merged commit f9f2b0b into knative:main Apr 1, 2026
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hack: remove deprecated GO111MODULE=on from hack scripts

3 participants