hack: remove deprecated GO111MODULE=on#16499
Conversation
GO111MODULE has been a no-op since Go 1.16 and is deprecated in Go 1.25. Modules are enabled by default; the explicit export can be safely removed.
|
Welcome @Ankitsinghsisodya! It looks like this is your first PR to knative/serving 🎉 |
|
Hi @Ankitsinghsisodya. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Pull request overview
Removes the deprecated GO111MODULE=on environment export from the remaining hack/ scripts that still set it, aligning them with the rest of the repo and avoiding deprecated/no-op configuration on modern Go.
Changes:
- Remove
export GO111MODULE=onfromhack/update-checksums.sh. - Remove
export GO111MODULE=onfromhack/update-reference-docs.sh.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| hack/update-reference-docs.sh | Drops deprecated GO111MODULE export before running reference-doc generation. |
| hack/update-checksums.sh | Drops deprecated GO111MODULE export before running checksum generation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ankitsinghsisodya, dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16499 +/- ##
==========================================
- Coverage 80.26% 80.18% -0.08%
==========================================
Files 217 217
Lines 13547 13547
==========================================
- Hits 10873 10863 -10
- Misses 2309 2318 +9
- Partials 365 366 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes #16498
Changes
Remove the
export GO111MODULE=online fromhack/update-checksums.shandhack/update-reference-docs.sh.GO111MODULEhas been a no-op since Go 1.16 and is deprecated in Go 1.25. All otherhack/scripts already omit it.