-
Notifications
You must be signed in to change notification settings - Fork 1.2k
minor refactoring of activator request metrics #16381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor refactoring of activator request metrics #16381
Conversation
|
/assign @linkvt |
|
@dprotaso: GitHub didn't allow me to request PR reviews from the following users: prashanthjos. Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16381 +/- ##
==========================================
- Coverage 80.26% 80.18% -0.09%
==========================================
Files 216 216
Lines 13483 13487 +4
==========================================
- Hits 10822 10814 -8
- Misses 2294 2306 +12
Partials 367 367 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@prashanthjos: changing LGTM is restricted to collaborators DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, prashanthjos The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
No description provided.