Skip to content

fix: preserve registry on OpenShift redeploy#3445

Draft
gauron99 wants to merge 1 commit intoknative:mainfrom
gauron99:push-kquorxtklmpr
Draft

fix: preserve registry on OpenShift redeploy#3445
gauron99 wants to merge 1 commit intoknative:mainfrom
gauron99:push-kquorxtklmpr

Conversation

@gauron99
Copy link
Contributor

/kind bug

Release Note

dont force openshift registry on redeploy

@knative-prow
Copy link

knative-prow bot commented Feb 19, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. labels Feb 19, 2026
@knative-prow
Copy link

knative-prow bot commented Feb 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 19, 2026
@gauron99 gauron99 changed the title fix: preserve user-speciffide registry on OpenShift redeploy fix: preserve registry on OpenShift redeploy Feb 19, 2026
@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 54.51%. Comparing base (53dcc03) to head (d707c8b).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
cmd/deploy.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3445   +/-   ##
=======================================
  Coverage   54.51%   54.51%           
=======================================
  Files         179      179           
  Lines       20274    20281    +7     
=======================================
+ Hits        11052    11057    +5     
- Misses       8050     8051    +1     
- Partials     1172     1173    +1     
Flag Coverage Δ
e2e 38.47% <80.00%> (+0.03%) ⬆️
e2e go 32.63% <40.00%> (+<0.01%) ⬆️
e2e node 28.54% <40.00%> (+<0.01%) ⬆️
e2e python 32.14% <40.00%> (+<0.01%) ⬆️
e2e quarkus 28.69% <40.00%> (+<0.01%) ⬆️
e2e rust 28.10% <40.00%> (+<0.01%) ⬆️
e2e springboot 26.56% <40.00%> (+<0.01%) ⬆️
e2e typescript 28.68% <40.00%> (+0.02%) ⬆️
integration 17.53% <0.00%> (-0.02%) ⬇️
unit macos-14 42.24% <80.00%> (+0.01%) ⬆️
unit macos-latest 42.24% <80.00%> (+0.01%) ⬆️
unit ubuntu-24.04-arm 42.56% <91.66%> (+0.02%) ⬆️
unit ubuntu-latest 43.13% <80.00%> (+0.01%) ⬆️
unit windows-latest 42.26% <80.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant