Skip to content

fix: create inline buildpack for python+pack#3425

Open
gauron99 wants to merge 1 commit intoknative:mainfrom
gauron99:push-ztoonmovwnon
Open

fix: create inline buildpack for python+pack#3425
gauron99 wants to merge 1 commit intoknative:mainfrom
gauron99:push-ztoonmovwnon

Conversation

@gauron99
Copy link
Contributor

@gauron99 gauron99 commented Feb 9, 2026

python + pack works now

  • Remove pyScaffoldInjector that hijacked Docker tar streams to inject scaffolding
  • Enable Python scaffolding via Scaffolder (writes to .func/build/ like Go)
  • Use inline pre-buildpack to rearrange workspace at build time (user code → fn/, scaffolding → root)
  • Replicate inline buildpack logic in Tekton task for remote builds
  • Add more scaffolding tests

/fixes #3405
/fixes #2985
/fixes #3007

@knative-prow
Copy link

knative-prow bot commented Feb 9, 2026

@gauron99: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

Details

In response to this:

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow
Copy link

knative-prow bot commented Feb 9, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2026
@knative-prow
Copy link

knative-prow bot commented Feb 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 9, 2026
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.94%. Comparing base (a42c16f) to head (859038d).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
pkg/buildpacks/scaffolder.go 78.94% 8 Missing and 4 partials ⚠️
pkg/buildpacks/builder.go 65.21% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3425      +/-   ##
==========================================
+ Coverage   54.51%   54.94%   +0.42%     
==========================================
  Files         179      178       -1     
  Lines       20274    20281       +7     
==========================================
+ Hits        11053    11143      +90     
+ Misses       8049     7960      -89     
- Partials     1172     1178       +6     
Flag Coverage Δ
e2e 38.60% <5.08%> (+0.15%) ⬆️
e2e go 32.79% <5.08%> (+0.15%) ⬆️
e2e node 28.56% <3.38%> (+0.01%) ⬆️
e2e python 33.14% <76.27%> (+0.99%) ⬆️
e2e quarkus 28.71% <3.38%> (+0.01%) ⬆️
e2e rust 28.12% <3.38%> (+0.01%) ⬆️
e2e springboot 26.56% <3.38%> (-0.01%) ⬇️
e2e typescript 28.67% <3.38%> (+0.01%) ⬆️
integration 17.57% <0.00%> (+<0.01%) ⬆️
unit macos-14 42.76% <62.71%> (+0.53%) ⬆️
unit macos-latest 42.76% <62.71%> (+0.53%) ⬆️
unit ubuntu-24.04-arm 43.02% <57.50%> (+0.48%) ⬆️
unit ubuntu-latest 43.65% <62.71%> (+0.52%) ⬆️
unit windows-latest 42.78% <62.71%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99 gauron99 force-pushed the push-ztoonmovwnon branch 3 times, most recently from 5d8d85c to ed688cd Compare February 11, 2026 08:15
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2026
@knative-prow-robot knative-prow-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 16, 2026
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 26, 2026
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 26, 2026
@gauron99 gauron99 force-pushed the push-ztoonmovwnon branch 4 times, most recently from 40da93f to 2bcd372 Compare February 27, 2026 08:46
@gauron99 gauron99 changed the title [WIP] python buildpack update fix: create inline buildpack for python+pack, remove docker injector workaround Feb 27, 2026
@gauron99 gauron99 changed the title fix: create inline buildpack for python+pack, remove docker injector workaround fix: create inline buildpack for python+pack Feb 27, 2026
@gauron99 gauron99 marked this pull request as ready for review February 27, 2026 13:54
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2026
@gauron99 gauron99 requested review from lkingland and matejvasek and removed request for dsimansk and jrangelramos February 27, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove python injector Unify the scaffolding! Func remote deploy python not work.

2 participants