Fix/test validated link target tempdir

[intojhanurag]

Fixed: #3197

[knative-prow]

Hi @intojhanurag. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.55%. Comparing base (fc761ce) to head (31ef526).
⚠️ Report is 50 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3223      +/-   ##
==========================================
+ Coverage   51.80%   54.55%   +2.75%     
==========================================
  Files         162      162              
  Lines       19132    19216      +84     
==========================================
+ Hits         9912    10484     +572     
+ Misses       8242     7688     -554     
- Partials      978     1044      +66     

Flag	Coverage Δ
e2e	39.68% <ø> (?)
e2e go	35.61% <ø> (?)
e2e node	30.98% <ø> (?)
e2e python	35.34% <ø> (?)
e2e quarkus	31.12% <ø> (?)
e2e rust	30.50% <ø> (?)
e2e springboot	30.58% <ø> (?)
e2e typescript	31.10% <ø> (?)
integration	17.90% <ø> (+0.02%)	⬆️
unit macos-14	44.33% <ø> (-0.05%)	⬇️
unit macos-latest	44.33% <ø> (-0.05%)	⬇️
unit ubuntu-24.04-arm	44.53% <ø> (-0.04%)	⬇️
unit ubuntu-latest	45.25% <ø> (-0.07%)	⬇️
unit windows-latest	44.35% <ø> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[intojhanurag]

Hey @lkingland , Now it is ready for review . Please take a look , if you have a moment.

[gauron99]

This PR (and also I have seen a similar one recently perhaps from you @intojhanurag as well) removes the test leftover files, we should remove those .gitignore paths now that they are no longer necessary as part of cleanup

[intojhanurag]

Hey @gauron99 , I think there was two-three issues of same type but not exactly same .

[lkingland]

Looking good!

I made a little comment on the issue itself. Can we either 1) open a new issue to track hunting down any other tests which create those links or 2) fix them as part of this issue #3197. That way we can reach the final goal of being able to remove those lines from .gitignore 👍🏻

[intojhanurag]

Hey @lkingland, I first deleted both files from the repo where they were being created, then I ran "make test". I checked, and they were not created again.
So I’m assuming the problem is solved, and I also removed both file locations from .gitignore.
Let me know if my approach is wrong.

[gauron99]

Ideally I would like to make sure this is FOR SURE removed so we dont have to go back and forth. Ideally running make test-full. Im not sure what tests exactly interact with those files from the top of my head, perhaps not needed.

If you're not sure lets keep the issue open so we know its not completely finished/investigated and please edit the issue to track what has been done and what hasnt, thanks!

[intojhanurag]

Hey @gauron99 , Idk why "make test-full" command stuck in my laptop . but i checked on "make test" there is no file creating. btw we can keep open till then.

[gauron99]

test-full requires you to setup the cluster with some extra scripts along the way. Its all in hack directory. You should be able to run hack/binaries.sh && hack/cluster.sh && hack/registry.sh && hack/gitlab.sh The names might be slightly off but in general

[lkingland]

Looking good!
If those files sneak back in, I'll open a new issue
(I have the ability to run make test-full already set up)

👍

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: intojhanurag, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [lkingland]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gauron99]

This PR partially fixes #3158; taking care of the absoluteLink* files