Modernised icons and asset management#1530
Modernised icons and asset management#1530neofelis2X wants to merge 20 commits intokliment:masterfrom
Conversation
|
Hi, I downloaded all windows binaries. The Pronterface x86-py3.8 version do not work and call a exception error. I had the same problem when I compiled it locally in the past. Interestingly the compiled versions from GitHub had not this problem in the past. This is why I wrote the reminder in release_windows. bat and mark this combination as not supported but let it compile on GitHub. Guess we need to exclude it for now in the action file, what expected from my side. But I will have a separate look on it in my PR for Python 3.14 as is want to test all Python versions / combinations for Windows again. I had seen you reversed the license classifier change in pyproject.toml. Interestingly adding only license = "GPL-3.0-or-later" under [Project] had worked for me for local builds with py3.14. |
|
You can revert the revert. Change license to Edit: Edit2: |
I agree that is alot of new files. All the expected resolutions for the different platforms.
Yes this used to be the correct way of writing it. But with current tools I get this deprecation warning: So the end goal will be to support setuptools >= 77 for all build runs? What should we do here for now? I guess it is better to make a separate PR that handles all the build updates.
That could be... Setuptools is the most contradicting and unintuitive thing I have ever seen. I tried to cleanly update how the data files are packed, but it certainly can be improved. I also felt like this PR is changing too many things already. |
Yes, but we can deal with it next year. For the time being we can use Maybe we are able to push one more official release with the actual changes (this PR and the other from you and in addition my PR for supporting py3.14) |
|
Hi, I wasn't getting GitHub emails for some reason and I missed this. I hope to have this reviewed by mid February. |
Summary
Hello,
I had this cooking for a long time now and decided to push it, to avoid overlapping work. This PR started with new icons, but then I also had to change how they are stored, packed and loaded.
Note: I made some of these changes to the filestructure because I need to load shaders for OpenGL 3 later.
Screenshots
WINDOWS (click to expand)
MACOS (click to expand)
Comments
This fixes #1529
I guess it is a bit much in one PR, but it all kinda belongs together. Let me know what you think. Feedback is welcome, as always!