p/pronterface: Fix unknown wx locale#1351
Conversation
|
@rockstorm101, |
|
Forgot to mention that this fix work fine on my windows system. (but I wasn't able to reproduce this error on my windows computers). I would suggest to implement it as it is nice way to avoid a not defined language setup. |
Hi @DivingDuck, you say this because of the workflow failures I guess. It turns out GitHub was having issues on their servers yesterday. The workflows for Windows run well for PR #1352 today. Which takes me to, do we really need PR #1353 now? I guess it'll be needed some day at some point though. |
|
Hi @rockstorm101, I think we shouldn't build all those environments if we can't use them at all. wxpython 4.2 won't support any of this versions for windows. I like to minimize the use of resources (and possible errors for not used stuff). I must confess that I forgot to check this again when we build 2.0. For macOS it looks like they are on the way to stop support for macOS 10.15: |
|
Hello @rockstorm101 . I tested this and doesn't cause any errors on macOS. Looks good to me! |
Function
wx.Locale.GetSystemLanguagereturnswx.LANGUAGE_UNKNOWNwhen unable to identify the system's language. Andwx.Localeconstructor does not allowwx.LANGUAGE_UNKNOWNas an argument.Fixes #1345
Fixes #1348
CC @DivingDuck @neofelis2X could you give this a try and confirm it works?