fix: npm and crates publishing issue related to dependency versions requiring MSRV 1.81#150
Merged
gk-kindred merged 11 commits intomasterfrom Sep 11, 2025
Merged
Conversation
napi-rs version 3 has breaking changes around cli and threadedFunctions and also has dependency on rust version > 1.8
remove rayon feature to remove MSRV 1.81 issue
This reverts commit 7ff8ab5.
hamisor
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR address two issues
cohort_sdk_jsstep, since napi-rs/cli is not pinned to a version, on GH actions, version 3 is installed. @napi-rs/cli version 3 has couple of breaking changes, and therefore opted to pin to the last possible version 2, till we are ready to move to version 3.call_asyncfrom threaded function which returns a value from callback and with version 3, this won't happen.2.a. We use
timecrate in most of our packages, and while publishing cargo doesn't use the lockfile to stick to the exact version as we used while building. Therefore path versions could automatically increment. This lead to one of the transient dependencyderangedwith MSRV 1.81. Therefore I have pinnedtimecrate to a version whose MSRV is below 1.81.2.b. Similar issue with
indexmapcrate used in replicator whenrayonfeature is enabled. This was enabled as part of some experiments during the initial days, and is not longer used. Alsoindexmapdependency on messenger was also obsolete and removed.The changes have been tested after releasing a beta version
0.3.9-beta.3