feat: replicator capture events for candidate to statemap install and publish metrics#149
Merged
gk-kindred merged 8 commits intomasterfrom Sep 9, 2025
Merged
Conversation
Collaborator
gk-kindred
commented
Sep 7, 2025
gk-kindred
commented
- Capture the various events in the journey from candidate and decision message to statemap install
- Capture metrics from the events for candidate message received to statemap install and decision message received to statemap install
- This lays the foundation for the capturing events for various points during the journey of candidate received and to when its corresponding statemaps were install. This could be exposed to consuming apps later to build their own metrics.
…in replicator use the events to capture metrics
hamisor
previously approved these changes
Sep 8, 2025
hamisor
left a comment
hamisor
left a comment
There was a problem hiding this comment.
LGTM. just couple of minor comments to remove the obsolete fields
| &version, | ||
| StatemapInstallerHashmap { | ||
| timestamp: OffsetDateTime::now_utc().unix_timestamp_nanos(), | ||
| // timestamp: OffsetDateTime::now_utc().unix_timestamp_nanos(), |
There was a problem hiding this comment.
I can see this is now replaced by StatemapEvents, suggest to remove timestamp
| pub struct StatemapInstallerHashmap { | ||
| // enqueued at | ||
| pub timestamp: i128, // nanos | ||
| // pub timestamp: i128, // nanos |
hamisor
reviewed
Sep 8, 2025
packages/talos_cohort_replicator/src/services/statemap_installer_service.rs
Show resolved
Hide resolved
hamisor
approved these changes
Sep 9, 2025
gk-kindred
deleted the
feature/overall-journey-metrics-for-replicator
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.