Add --detect-honeypots option and harden tool/attack robustness across the board#478
Closed
Add --detect-honeypots option and harden tool/attack robustness across the board#478
Conversation
Agent-Logs-Url: https://github.com/kimocoder/wifite2/sessions/e93d4250-8234-4a30-87ee-e546ca9b660c Co-authored-by: kimocoder <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import time | ||
| import os | ||
| import re | ||
| import subprocess |
Check notice
Code scanning / Bandit
Consider possible security implications associated with the subprocess module. Note
| try: | ||
| if hasattr(self, 'output_fh') and self.output_fh and not self.output_fh.closed: | ||
| self.output_fh.close() | ||
| except Exception: |
Check notice
Code scanning / Bandit
Try, Except, Pass detected. Note
| pass | ||
| try: | ||
| self.stop() | ||
| except Exception: |
Check notice
Code scanning / Bandit
Try, Except, Pass detected. Note
| self.pid.interrupt() | ||
| try: | ||
| self.pid.interrupt() | ||
| except Exception: |
Check notice
Code scanning / Bandit
Try, Except, Pass detected. Note
| try: | ||
| if hasattr(self, 'output_write') and self.output_write and not self.output_write.closed: | ||
| self.output_write.close() | ||
| except Exception: |
Check notice
Code scanning / Bandit
Try, Except, Pass detected. Note
Copilot
AI
changed the title
[WIP] Add --detect-honeypots CLI option and improve multiple areas
Add --detect-honeypots option and harden tool/attack robustness across the board
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the patch.patch changes: introduces a
--detect-honeypotsscanner feature and fixes a spread of robustness/cleanup issues across attack modules, tools, and the portal server.--detect-honeypotsfeature--detect-honeypotsarg →Configuration.detect_honeypotswired throughargs.py,config/__init__.py,defaults.py, andparsers/settings.pyutil/scanner.py): new_analyze_honeypots()called each scan cycle (airodump and native paths); setsis_honeypot,honeypot_score,honeypot_reasonson eachTarget; detects:HPcolumn in both classic and TUI (ui/scanner_view.py) views;Target.to_str()gainsshow_honeypotparameterModel normalization
model/client.py:powerandpacketsfield parsing wrapped intry/except (ValueError, IndexError)— previously would raise on malformed CSV rowsmodel/target.py: honeypot metadata fields initialized in__init__; propagated viatransfer_info()Evil twin / portal improvements
attack/eviltwin.py: adds_portal_credential_callback()and_validate_credentials()(8–63 char WPA length check); wires callback toPortalServer.set_credential_callback()— previously the portal captured credentials but never called back into the attackattack/portal/server.py:do_POSTnow enforcesMAX_POST_SIZE = 8192with a 413 response;content_lengthclamped to ≥ 0; decode useserrors='replace'PMKID
attack/pmkid.py:t.join(timeout=5)added afterkeep_capturing = Falseso the capture thread is reaped before returningProcess/tool hardening
attack/wpa.py: added missingimport subprocess(referenced but not imported in_error_recovery_context)tools/aircrack.py:__del__wrapped intry/except OSError; stdout decode useserrors='replace'tools/aireplay.py:__del__wraps both file close andstop()in separatetry/excepttools/airmon.py:os.kill()interminate_conflicting_processescatchesProcessLookupError/PermissionErrortools/airodump.py:pid.interrupt()in__exit__wrapped intry/excepttools/hashcat.py:HcxDumpTool.__init__file removal wrapped intry/except OSErrortools/reaver.py:__del__and pre-run file removal hardened withtry/exceptFormatting
requirements.txt: movedurllib3inline comment to its own lineOriginal prompt
This pull request was created from Copilot chat.
⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.