fetch-macOS-v2: honour --outdir with --shortname, and stop hiding failures - #280
Open
gmipf wants to merge 1 commit into
Open
fetch-macOS-v2: honour --outdir with --shortname, and stop hiding failures#280gmipf wants to merge 1 commit into
gmipf wants to merge 1 commit into
Conversation
…lures Two problems in the same code path: - --outdir is ignored when --shortname is used, so the download always lands in the working directory no matter what was asked for - a failed download is swallowed and the script still exits successfully, so a caller cannot tell an empty result from a finished one Respect the requested output directory in both paths, and let a failure be a failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two problems in the same code path:
--outdiris ignored when--shortnameis used, so the download always lands in the working directory regardless of what was asked forThis respects the requested output directory in both paths, and lets a failure be a failure.
Prepared with AI assistance (Claude Opus 4.8) and reviewed before submission.