Implement percent operators for config files#49
Open
rminnich wants to merge 1 commit intokevinburke:masterfrom
Open
Implement percent operators for config files#49rminnich wants to merge 1 commit intokevinburke:masterfrom
rminnich wants to merge 1 commit intokevinburke:masterfrom
Conversation
There are still one or two missing; consider this a draft until they are finished. Also, fix one or two nits found by golint. This change introduces no new findings by golint, go vet, and golangci-lint. Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Owner
|
Hey, just following up here - you mentioned this is a draft, are there other changes that need to be made? |
Author
|
oops, sorry, this should no longer be draft, how does it look to you. I missed your review :-( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are still one or two missing; consider this a draft
until they are finished.
Also, fix one or two nits found by golint.
This change introduces no new findings by
golint, go vet, and golangci-lint.
Signed-off-by: Ronald G. Minnich rminnich@gmail.com