Skip to content

fix(bigquery): replace unbounded Flux BUFFER with Flux.fromStream in Query.storeResult #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fdelbrayelle merged 1 commit into from
Apr 28, 2026
+4 −16
Merged

fix(bigquery): replace unbounded Flux BUFFER with Flux.fromStream in Query.storeResult #605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 4 additions & 16 deletions src/main/java/io/kestra/plugin/gcp/bigquery/Query.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
import lombok.*;
import lombok.experimental.SuperBuilder;
import reactor.core.publisher.Flux;
import reactor.core.publisher.FluxSink;
import reactor.core.publisher.Mono;

@SuperBuilder
Expand Down Expand Up @@ -661,21 +660,10 @@ private Map.Entry<URI, Long> storeResult(TableResult result, RunContext runConte
try (
var output = new BufferedWriter(new FileWriter(tempFile), FileSerde.BUFFER_SIZE)
) {
Flux<Object> flowable = Flux
.create(
s ->
{
StreamSupport
.stream(result.iterateAll().spliterator(), false)
.forEach(fieldValues ->
{
s.next(this.convertRows(result, fieldValues));
});

s.complete();
},
FluxSink.OverflowStrategy.BUFFER
);
Flux<Object> flowable = Flux.fromStream(
StreamSupport.stream(result.iterateAll().spliterator(), false)
.map(fieldValues -> (Object) this.convertRows(result, fieldValues))
);
Mono<Long> longMono = FileSerde.writeAll(output, flowable);

// metrics & finalize
Expand Down
Loading