Fix: convert deque to list before tf.transpose in keras.ops.quantile

[Junead04]

Summary
Fixed a ValueError in keras.ops.quantile when running under TensorFlow graph execution (@tf.function).
The issue was caused by passing a collections.deque object as the perm argument to tf.transpose.

Fix
Fixes #21781
Convert perm to a list before passing it to TensorFlow:
result = tf.transpose(result, perm=list(perm))

Test
Added a regression test verifying correct behavior under tf.function.
CC: @keras-team

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @Junead04, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical bug affecting the keras.ops.quantile function when used within TensorFlow's graph execution mode (@tf.function). The issue stemmed from an incompatibility between tf.transpose and collections.deque objects. The fix ensures proper operation by explicitly converting the permutation argument to a list, and a new test case has been introduced to prevent future regressions.

Highlights

• Bug Fix: Addresses a ValueError that occurred in keras.ops.quantile when executed within a TensorFlow graph (@tf.function).
• Root Cause: The error was caused by passing a collections.deque object as the perm argument to tf.transpose, which is not supported in TensorFlow's graph execution mode.
• Solution: The perm argument is now explicitly converted to a standard Python list before being passed to tf.transpose, resolving the compatibility issue.
• Testing: A new regression test, test_quantile_graph_mode, has been added to verify the correct behavior of keras.ops.quantile when running under tf.function.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a ValueError in keras.ops.quantile when used within a @tf.function in TensorFlow. The fix correctly converts a collections.deque object to a list before passing it to tf.transpose, which resolves the graph execution issue. A new regression test is also added to ensure this behavior is correct and prevent future regressions. The changes are accurate and well-tested. The pull request is well-structured and ready to be merged.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.80%. Comparing base (c2bc6cf) to head (95514ee).
⚠️ Report is 144 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #21784      +/-   ##
==========================================
+ Coverage   82.63%   82.80%   +0.16%     
==========================================
  Files         577      592      +15     
  Lines       59316    62289    +2973     
  Branches     9300     9751     +451     
==========================================
+ Hits        49018    51576    +2558     
- Misses       7910     8190     +280     
- Partials     2388     2523     +135     

Flag	Coverage Δ
keras	82.62% <ø> (+0.16%)	⬆️
keras-jax	62.42% <ø> (-0.90%)	⬇️
keras-numpy	56.56% <ø> (-1.00%)	⬇️
keras-openvino	37.57% <ø> (+3.28%)	⬆️
keras-tensorflow	63.67% <ø> (-0.45%)	⬇️
keras-torch	62.44% <ø> (-1.19%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[keerthanakadiri]

Hi @Junead04, Can you please sign the CLA? Thank you!

[hertschuh]

Thanks for the fix!

[hertschuh]

This test already exists:

keras/keras/src/ops/numpy_test.py

Line 3347 in d662ac7

def test_quantile_in_tf_function(self):

Can you remove this file and modify the existing test to cover the case that was not working?

[hertschuh]

You'll also need to accept the CLA.

[Junead04]

Okk I will sign into the CLA.This is my first contribution so I don't know about this.Thank you for guiding me @keerthanakadiri @hertschuh

[hertschuh]

Okk I will sign into the CLA.This is my first contribution so I don't know about this.Thank you for guiding me @keerthanakadiri @hertschuh

@Junead04

In the failing checks below, click on "cla/google", it will take you to a page that explains things and there will be another link to click to accept the CLA.

[github-actions]

This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you.

[Junead04]

I sign in CLA sorry for late but when I rescan this PR it is showing error.

[hertschuh]

Can you address the PR comments and run the code formatter? Thanks!

https://github.com/keras-team/keras/blob/master/CONTRIBUTING.md#generating-public-api-and-formatting-the-code

[github-actions]

This PR is stale because it has been open for 14 days with no activity. It will be closed if no further activity occurs. Thank you.

[github-actions]

This PR was closed because it has been inactive for 28 days. Please reopen if you'd like to work on this further.

[hertschuh]

Thanks!