feat: add health check in echo sql compose db - #176
Merged
Conversation
Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a health check configuration to the PostgreSQL service in the docker-compose.yml file for the echo-sql project. The change ensures that dependent services wait for the database to be fully ready before starting.
- Added health check configuration to the postgres service using pg_isready command
- Updated the depends_on configuration to use the service_healthy condition
- Removed commented-out volume mount for postgres-data
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
khareyash05
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.