GalleryAdults: Fix app crash#13346
Merged
AwkwardPeak7 merged 1 commit intokeiyoushi:mainfrom Feb 14, 2026
Merged
Conversation
Fetch pages sequentially to avoid concurrent modification of the list java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String eu.kanade.tachiyomi.multisrc.galleryadults.Genre.getName()' on a null object reference
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an app crash caused by a NullPointerException when attempting to access Genre names. The root cause was concurrent modification of the tags list during parallel page fetching. The fix changes tag fetching from concurrent to sequential execution to prevent race conditions.
Changes:
- Replaced concurrent tag fetching (using
runBlocking,Job, andjoinAll) with sequential fetching usingforEach - Added proper resource cleanup with
.use { }for HTTP response handling - Improved exception handling with
finallyblock to ensuretagsFetchAttemptis always incremented - Applied code style improvements (expression body functions, formatting)
- Incremented
baseVersionCodefrom 5 to 6
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib-multisrc/galleryadults/src/eu/kanade/tachiyomi/multisrc/galleryadults/GalleryAdults.kt | Fixed concurrent modification bug by switching to sequential tag fetching; added proper resource cleanup; applied code style improvements |
| lib-multisrc/galleryadults/build.gradle.kts | Incremented baseVersionCode to 6 to reflect the bug fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AwkwardPeak7
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetch pages sequentially to avoid concurrent modification of the list
java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String eu.kanade.tachiyomi.multisrc.galleryadults.Genre.getName()' on a null object referenceChecklist:
extVersionCodevalue inbuild.gradlefor individual extensionsoverrideVersionCodeorbaseVersionCodeas needed for all multisrc extensionsisNsfw = trueflag inbuild.gradlewhen appropriateidif a source's name or language were changedweb_hi_res_512.pngwhen adding a new extension