Remove behaviour forcing types to be first in exports#398
Merged
keithamus merged 1 commit intokeithamus:mainfrom Jan 25, 2026
Merged
Remove behaviour forcing types to be first in exports#398keithamus merged 1 commit intokeithamus:mainfrom
keithamus merged 1 commit intokeithamus:mainfrom
Conversation
Owner
|
It would be useful to have a test demonstrating the failure mode here. For example this simply removes the existing tests, but instead altering them to prove that |
a1187a7 to
f847947
Compare
Contributor
Author
|
Updated tests to include negative cases. Fixes #393 |
fisker
approved these changes
Jan 24, 2026
|
🎉 This PR is included in version 3.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forcing
"types"to be first in every export map breaks the fundamentals of custom conditions, in which package owners determine the priority order of conditions, including their own 'user conditions'.Forcing
"types"to be first in all exports is a regression we experienced breaking all builds in our monorepo via https://github.com/matzkoh/prettier-plugin-packagejsonIn that last article (written by the author of zod) is this very specific guidance, which is impossible when formatted by
sort-package-jsonsince3.5.0