Skip to content

added default max scale for oracle #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hmiguim merged 1 commit into from
Jan 14, 2025
Merged

added default max scale for oracle #634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...c/main/java/com/databasepreservation/modules/oracle/in/Oracle12cJDBCDatatypeImporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ public class Oracle12cJDBCDatatypeImporter extends JDBCDatatypeImporter {
private static final Logger LOGGER = LoggerFactory.getLogger(Oracle12cJDBCDatatypeImporter.class.getName());
private static final int CHAR_MIN_COLUMN_SIZE_VALUE = 1;
private static final int NUMERIC_MAX_COLUMN_SIZE_VALUE = 38;
private static final int NUMERIC_MAX_COLUMN_DECIMAL_DIGITS_VALUE = 127;

@Override
protected Type getNumericType(String typeName, int columnSize, int decimalDigits, int numPrecRadix) {
Expand All @@ -39,8 +40,8 @@ protected Type getNumericType(String typeName, int columnSize, int decimalDigits
if (columnSize == 0) {
LOGGER.debug("Column data length is 0 replacing the length to the max data length {}",
NUMERIC_MAX_COLUMN_SIZE_VALUE);
type.setSql99TypeName("NUMERIC", NUMERIC_MAX_COLUMN_SIZE_VALUE);
type.setSql2008TypeName("NUMERIC", NUMERIC_MAX_COLUMN_SIZE_VALUE);
type.setSql99TypeName("NUMERIC", NUMERIC_MAX_COLUMN_SIZE_VALUE, NUMERIC_MAX_COLUMN_DECIMAL_DIGITS_VALUE);
type.setSql2008TypeName("NUMERIC", NUMERIC_MAX_COLUMN_SIZE_VALUE, NUMERIC_MAX_COLUMN_DECIMAL_DIGITS_VALUE);
} else {
if (decimalDigits > 0) {
type.setSql99TypeName("NUMERIC", columnSize, decimalDigits);
Expand Down
Loading