Several updates/fixes to the options passed to browsers#277
Open
solonovamax wants to merge 1 commit intokarma-runner:masterfrom
Open
Several updates/fixes to the options passed to browsers#277solonovamax wants to merge 1 commit intokarma-runner:masterfrom
solonovamax wants to merge 1 commit intokarma-runner:masterfrom
Conversation
- Extract common options from ChromeBrowser and ChromiumBrowser
- Introduce function `getOptions`
- Introduce options to chromium for parity
- Add --disable-renderer-backgrounding
- Add --disable-device-discovery-notifications
- Introduce new options
- Introduce options to prevent password dialogs when running tests
- Add --password-store=basic. Prevents gnome keyring/kde wallet popup on Linux
- Add --use-mock-keychain. Prevents permissions dialog on Mac.
- Introduce options to disable interactivity
- Add --disable-popup-blocking
- Add --disable-notifications
- Add --mute-audio
- Add --disable-client-side-phishing-detection
- Replace removed flags
- Replace --disable-translate with --disable-features=Translate
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following changes:
ChromeBrowserandChromiumBrowser.getOptionsinstead of duplicating code.Previously, chrome had these options added to it to fix a bug, however they were not added to chromium.
--disable-renderer-backgroundingto chromium--disable-device-discovery-notificationsto chromium--password-store=basic. Prevents gnome keyring/kde wallet popup on Linux.--use-mock-keychain. Prevents permissions dialog on Mac.--disable-popup-blocking. Disables the "block popups" dialog.--disable-notifications. Disable notifications.--mute-audio. Mute audio.--disable-client-side-phishing-detection. Disables client-side phishing detection.--disable-translatewith--disable-features=TranslateI personally was running into an issue with the lack of
--password-store=basiccausing chromium to repeatedly prompt for a password when running tests. Originally, this PR was going to only introduce that flag, however while modifying the code to add this, I noticed a few other minor changes I could do, which is why this PR contains a few changes.If any of the new flags introduced are blocking a merge, then I can remove them, as I'd like to get
--password-store=basicmerged.