Skip to content

Infra: Remove io.modelcontextprotocol.sdk:mcp-spring-webflux from the Spring boot group#1594

Merged
Haarolean merged 1 commit intokafbat:mainfrom
yeikel:patch-5
Dec 26, 2025
Merged

Infra: Remove io.modelcontextprotocol.sdk:mcp-spring-webflux from the Spring boot group#1594
Haarolean merged 1 commit intokafbat:mainfrom
yeikel:patch-5

Conversation

@yeikel
Copy link
Copy Markdown
Collaborator

@yeikel yeikel commented Dec 23, 2025

What changes did you make? (Give an overview)

In #1542, we chose to include the io.modelcontextprotocol.sdk:mcp-spring-webflux dependency under the Spring Boot group, since it depends on Spring Boot and it is reasonable to test and upgrade them together.

One challenge with this dependency is that it introduces breaking changes in minor releases, which can unexpectedly break minor and patch-level Spring Boot dependency upgrades (for example, #1591
).

While it is permitted to create breaking changes under semantic versioning rules for 0.x versions, Dependabot does not differentiate this case and treats such updates as regular patch releases.

To avoid breaking our group and not getting the full benefit of Dependabot, we'll handle this dependency separately for now until it reaches 1.0.0

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

A picture of a cute animal (not mandatory but encouraged)

image

@yeikel yeikel requested a review from a team as a code owner December 23, 2025 23:15
@kapybro kapybro bot added status/triage Issues pending maintainers triage scope/infra CI, CD, dev. env, etc. status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Dec 23, 2025
@yeikel
Copy link
Copy Markdown
Collaborator Author

yeikel commented Dec 23, 2025

@Haarolean Could you please check this out?

@Haarolean Haarolean removed the status/triage/manual Manual triage in progress label Dec 26, 2025
@Haarolean Haarolean merged commit 7a4d2e9 into kafbat:main Dec 26, 2025
11 of 12 checks passed
@yeikel yeikel deleted the patch-5 branch December 26, 2025 17:44
@yeikel
Copy link
Copy Markdown
Collaborator Author

yeikel commented Dec 26, 2025

Thank you, @Haarolean

Merging this unblocked #1596 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants