Clarify K3s manifest overrides and HelmChartConfig#1626
Open
agyss wants to merge 1 commit intok3d-io:mainfrom
Open
Clarify K3s manifest overrides and HelmChartConfig#1626agyss wants to merge 1 commit intok3d-io:mainfrom
agyss wants to merge 1 commit intok3d-io:mainfrom
Conversation
Updated notes on K3s manifests and HelmChartConfig usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated notes on K3s manifests and HelmChartConfig usage.
What
Clarify that overwritting built-in components is not supported with normal mounts but HelmChartConfigs should be used.
Why
The current documentation wrongly states that mounting coredns.yml as in the config will override the packaged CoreDNS component. These changes would however be reverted.
Implications
No changes beside clearer docu.