fix: add label to skip coredns injection at cluster creation and start#1612
Open
maltelehmann wants to merge 2 commits intok3d-io:mainfrom
Open
fix: add label to skip coredns injection at cluster creation and start#1612maltelehmann wants to merge 2 commits intok3d-io:mainfrom
maltelehmann wants to merge 2 commits intok3d-io:mainfrom
Conversation
add new LabelClusterCoreDNSDisabled label to track CoreDNS disabled state, such that CoreDNS injection is skipped at cluster creation and start fixes k3d-io#1610
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new cluster label to track CoreDNS disabled state and skip CoreDNS injection during cluster creation and startup operations.
- Introduces
LabelClusterCoreDNSDisabledconstant to track when CoreDNS is disabled - Updates cluster configuration transformation to detect
--disable corednsarguments and set the label - Modifies cluster startup logic to check the label instead of parsing K3s arguments
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/types/types.go | Adds new label constant for tracking CoreDNS disabled state |
| pkg/config/transform.go | Detects CoreDNS disable flag and sets cluster label during configuration transformation |
| pkg/client/cluster.go | Updates startup logic to use label-based CoreDNS detection instead of argument parsing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
add new LabelClusterCoreDNSDisabled label to track CoreDNS disabled state, such that CoreDNS injection is skipped at cluster creation and start
Why
fixes #1610
Implications
This fix only works for cluster already created with this fix.