Skip to content

fix: add label to skip coredns injection at cluster creation and start#1612

Open
maltelehmann wants to merge 2 commits intok3d-io:mainfrom
maltelehmann:main
Open

fix: add label to skip coredns injection at cluster creation and start#1612
maltelehmann wants to merge 2 commits intok3d-io:mainfrom
maltelehmann:main

Conversation

@maltelehmann
Copy link
Copy Markdown

What

add new LabelClusterCoreDNSDisabled label to track CoreDNS disabled state, such that CoreDNS injection is skipped at cluster creation and start

Why

fixes #1610

Implications

This fix only works for cluster already created with this fix.

add new LabelClusterCoreDNSDisabled label to track CoreDNS disabled
state, such that CoreDNS injection is skipped at cluster creation and
start

fixes k3d-io#1610
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new cluster label to track CoreDNS disabled state and skip CoreDNS injection during cluster creation and startup operations.

  • Introduces LabelClusterCoreDNSDisabled constant to track when CoreDNS is disabled
  • Updates cluster configuration transformation to detect --disable coredns arguments and set the label
  • Modifies cluster startup logic to check the label instead of parsing K3s arguments

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
pkg/types/types.go Adds new label constant for tracking CoreDNS disabled state
pkg/config/transform.go Detects CoreDNS disable flag and sets cluster label during configuration transformation
pkg/client/cluster.go Updates startup logic to use label-based CoreDNS detection instead of argument parsing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread pkg/config/transform.go Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants