Fix corpus_dir in timit prep.

[ialmajai]

Lhotse prep. for Timit expects corpus_dir to be "$dl_dir/timit" instead of "$dl_dir/timit/data"

Summary by CodeRabbit

• Chores
  • Updated TIMIT dataset preparation path configuration.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The TIMIT ASR data preparation script's Stage 1 command path argument was modified. The input path for the lhotse prepare timit command changed from $dl_dir/timit/data to $dl_dir/timit, adjusting where the script locates source data for manifest preparation.

Changes

Cohort / File(s)	Summary
TIMIT Data Preparation Path Update egs/timit/ASR/prepare.sh	Stage 1: Modified lhotse prepare timit input path from $dl_dir/timit/data to $dl_dir/timit, removing the data subdirectory from the expected directory structure

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A path through the TIMIT woods so deep,
One level less for data to keep,
From /data subdirs we gently retreat,
Now timit itself makes the path complete!
Ready to hop through manifests anew, 🌟

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Fix corpus_dir in timit prep' directly addresses the main change: correcting the corpus directory path for TIMIT preparation as described in the PR objectives.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0904e49 and 2a6a229.

📒 Files selected for processing (1)

• egs/timit/ASR/prepare.sh

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (50)

• GitHub Check: py3.10 torch2.7.1 v20250630
• GitHub Check: py3.10 torch2.7.0 v20250630
• GitHub Check: py3.10 torch2.5.1 v20250630
• GitHub Check: py3.10 torch2.7.1 v20250630
• GitHub Check: py3.10 torch2.2.2 v20250630
• GitHub Check: py3.10 torch2.7.1 v20250630
• GitHub Check: py3.10 torch2.7.0 v20250630
• GitHub Check: py3.10 torch2.5.1 v20250630
• GitHub Check: py3.10 torch2.7.1 v20250630
• GitHub Check: py3.10 torch2.2.2 v20250630
• GitHub Check: py3.10 torch2.7.1 v20250630
• GitHub Check: py3.10 torch2.7.0 v20250630
• GitHub Check: py3.10 torch2.5.1 v20250630
• GitHub Check: py3.10 torch2.7.1 v20250630
• GitHub Check: py3.10 torch2.2.2 v20250630
• GitHub Check: py3.10 torch2.7.1 v20250630
• GitHub Check: py3.10 torch2.7.0 v20250630
• GitHub Check: py3.10 torch2.5.1 v20250630
• GitHub Check: py3.10 torch2.7.1 v20250630
• GitHub Check: py3.10 torch2.2.2 v20250630
• GitHub Check: py3.10 torch2.7.1 v20250630
• GitHub Check: py3.10 torch2.7.0 v20250630
• GitHub Check: py3.10 torch2.5.1 v20250630
• GitHub Check: py3.10 torch2.7.1 v20250630
• GitHub Check: py3.10 torch2.2.2 v20250630
• GitHub Check: py3.10 torch2.7.1 v20250630
• GitHub Check: py3.10 torch2.7.0 v20250630
• GitHub Check: py3.10 torch2.5.1 v20250630
• GitHub Check: py3.10 torch2.7.1 v20250630
• GitHub Check: py3.10 torch2.2.2 v20250630
• GitHub Check: py3.10 torch2.7.1 v20250630
• GitHub Check: py3.10 torch2.7.0 v20250630
• GitHub Check: py3.10 torch2.5.1 v20250630
• GitHub Check: py3.10 torch2.7.1 v20250630
• GitHub Check: py3.10 torch2.2.2 v20250630
• GitHub Check: py3.10 torch2.7.1 v20250630
• GitHub Check: py3.10 torch2.7.0 v20250630
• GitHub Check: py3.10 torch2.5.1 v20250630
• GitHub Check: py3.10 torch2.7.1 v20250630
• GitHub Check: py3.10 torch2.2.2 v20250630
• GitHub Check: py3.10 torch2.7.1 v20250630
• GitHub Check: py3.10 torch2.7.0 v20250630
• GitHub Check: py3.10 torch2.5.1 v20250630
• GitHub Check: py3.10 torch2.7.1 v20250630
• GitHub Check: py3.10 torch2.2.2 v20250630
• GitHub Check: py3.10 torch2.7.1 v20250630
• GitHub Check: py3.10 torch2.7.0 v20250630
• GitHub Check: py3.10 torch2.5.1 v20250630
• GitHub Check: py3.10 torch2.7.1 v20250630
• GitHub Check: py3.10 torch2.2.2 v20250630

🔇 Additional comments (1)

egs/timit/ASR/prepare.sh (1)

94-94: Path argument is correct for Lhotse's current API.

The change to $dl_dir/timit aligns with Lhotse's documented expectations: the corpus_dir parameter should reference the top-level TIMIT directory containing the TRAIN and TEST subdirectories, not a /data subdirectory. This matches the download output location on line 76 and the documented directory structure.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}