Open
Conversation
3b0f397 to
9f547f9
Compare
9f547f9 to
1678ffa
Compare
Contributor
Author
|
@k-takata Hi, do you have a chance to review this? I've applied to Ruby this patch (imasahiro/ruby@860d60c) and it seems benchmark result shows not bad number (with https://benchmarksgame-team.pages.debian.net/benchmarksgame/program/regexredux-ruby-3.html (which checks regexp library performance) become 8% faster than current master branch.) |
Contributor
Author
|
Hi~ any update so far...? @k-takata |
Contributor
Author
|
ping @k-takata |
Contributor
Author
|
Or is this repo already obsoleted? Then should I send a PR to https://github.com/ruby/ruby instead for example? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivations:
Changes:
Results:
\b\w+nn\b) at least at M1 mac (will check perf at other platform e.g. x86 later)Here are benchmark scores. Benchmark suite is derived form http://sljit.sourceforge.net/regex_perf.html.