feat: expose AmqpConnectionManagerClass#181
Merged
jwalton merged 6 commits intojwalton:expose-amqpconnectionmanagerfrom Sep 21, 2021
Merged
feat: expose AmqpConnectionManagerClass#181jwalton merged 6 commits intojwalton:expose-amqpconnectionmanagerfrom
jwalton merged 6 commits intojwalton:expose-amqpconnectionmanagerfrom
Conversation
Provided that they consumed with the channel wrapper function `consume`
feat: reconnect and cancelAll consumers
# [3.6.0](jwalton/node-amqp-connection-manager@v3.5.2...v3.6.0) (2021-08-27) ### Features * reconnect and cancelAll consumers ([fb0c00b](jwalton@fb0c00b))
The naming is strange because I don't want to introduce any breaking change. Note that jest complains about leaking resources due to: amqp-node/amqplib#584
luddd3
force-pushed
the
feat/expose-amqpconnectionmanager
branch
from
e86ed3c to
835a81f
Compare
jwalton
changed the base branch from
master
to
expose-amqpconnectionmanager
jwalton
added a commit
that referenced
this pull request
Sep 21, 2021
Owner
|
Merged to master via d209cb5. |
Owner
|
🎉 This PR is included in version 3.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the underlying class and extracts the connect method
its constructor. The reason for this is that we might want to
initiate the connection later or await its result. With this code
change we can also more easily reject on operational errors and
set a timeout for the initial connect.
The naming is strange because I don't want to introduce any
breaking change.
Note that jest complains about leaking resources due to:
amqp-node/amqplib#584