feat(envoy-proxy): add ALB access logging support with S3 bucket policy - #218
Open
itsharshvb wants to merge 1 commit into
Open
feat(envoy-proxy): add ALB access logging support with S3 bucket policy#218itsharshvb wants to merge 1 commit into
itsharshvb wants to merge 1 commit into
Conversation
Enable ALB access logs to be pushed to the envoy logs S3 bucket with proper ELB service permissions. Uses the S3 bucket module built-in attach_elb_log_delivery_policy for created buckets and data.aws_elb_service_account for existing buckets, avoiding stale hardcoded ELB account IDs. - Add enable_alb_access_logs variable (default true, no-op if create_lb=false) - Add alb_access_logs_prefix variable for custom S3 key prefix - Add data.aws_elb_service_account for dynamic ELB account resolution - Add access_logs block to ALB module conditionally - Add S3 bucket policy for existing bucket scenario - Add outputs: alb_access_logs_enabled, alb_access_logs_bucket, alb_access_logs_prefix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable ALB access logs to be pushed to the envoy logs S3 bucket with proper ELB service permissions. Uses the S3 bucket module built-in attach_elb_log_delivery_policy for created buckets and data.aws_elb_service_account for existing buckets, avoiding stale hardcoded ELB account IDs.