Allow configuration of text similarity threshold and improve default#799
Open
zmbc wants to merge 2 commits intojupyter:mainfrom
Open
Allow configuration of text similarity threshold and improve default#799zmbc wants to merge 2 commits intojupyter:mainfrom
zmbc wants to merge 2 commits intojupyter:mainfrom
Conversation
Carreau
reviewed
Feb 5, 2026
Carreau
reviewed
Feb 5, 2026
Carreau
reviewed
Feb 5, 2026
Carreau
reviewed
Feb 5, 2026
Member
|
generally +1 on this, maybe some small refactor and make sure we don't change API. |
Author
|
@Carreau I believe I've addressed all your comments! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #785.
Note that I have conservatively made this change only affect the comparison of cell sources. I think you could make an argument that an analogous change for outputs would also be good, but that would have had much larger impacts on the test suite.