Minimal change to permit non-interactive html diff generation (#468)#744
Open
cjerdonek wants to merge 1 commit intojupyter:mainfrom
Open
Minimal change to permit non-interactive html diff generation (#468)#744cjerdonek wants to merge 1 commit intojupyter:mainfrom
cjerdonek wants to merge 1 commit intojupyter:mainfrom
Conversation
|
for those who can't wait for the merge and want this functionality, simply run before trying out the gist provided |
Author
|
Thanks, @sizhky. I have no idea why someone "thumbs-downed" this PR when there are no other simple work-arounds available. I've been using this PR with my team for two months now without issues (in conjunction with code similar to what's in the gist). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minimal PR to support addressing issue #468. Specifically, it contains a minimal code change needed to let html diffs be created non-interactively (e.g. from the command-line in CI) without having to patch nbdime's source code. A gist demonstrating this (in conjunction with this PR) can be found here: https://gist.github.com/cjerdonek/2dad48eea22846476487d594cd906493
This PR also doesn't even require any changes to the default template, though the gist I wrote above does support providing your own template if you want (which again doesn't require modifying nbdime's source code).
My hope is that, because this PR has a lighter footprint than PR #552, it can provide an interim and more flexible way to address issue #468 in the short-term so people no longer have to patch or fork nbdime to get the benefit of off-line html diffs.