Move _repr_mimebundle_ to DOMWidgets#4011
Open
martinRenou wants to merge 1 commit intojupyter-widgets:mainfrom
Open
Move _repr_mimebundle_ to DOMWidgets#4011martinRenou wants to merge 1 commit intojupyter-widgets:mainfrom
martinRenou wants to merge 1 commit intojupyter-widgets:mainfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In bqplot we discovered that displaying a Mark was showing an error message (telling that the widget failed to render). This is because Marks are not DOMWidgets and we try to render them anyway.
This PR fixes it by moving the
_repr_mimebundle_implementation from Widget to DOMWidget.@jasongrout @maartenbreddels @ibdafna @SylvainCorlay do you have some thoughts, concerns?