Skip to content

Fix outdated ContentsManager testing guidance#1611

Open
terminalchai wants to merge 2 commits intojupyter-server:mainfrom
terminalchai:docs/fix-contents-testing-docs
Open

Fix outdated ContentsManager testing guidance#1611
terminalchai wants to merge 2 commits intojupyter-server:mainfrom
terminalchai:docs/fix-contents-testing-docs

Conversation

@terminalchai
Copy link
Copy Markdown

@terminalchai terminalchai commented Mar 22, 2026

Summary

  • replace the outdated jupyter_server.services.contents.tests module reference
  • document that the ContentsManager test suites now live in ests/services/contents in the source tree
  • clarify that custom backends should copy or adapt those tests instead of importing them from the installed package

Testing

  • d:/project_contribution/.venv/Scripts/python.exe -m sphinx -b html -W -q docs/source docs/build/html docs/source/developers/contents.rst

Closes #394

Copy link
Copy Markdown
Member

@lresende lresende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krassowski krassowski changed the title docs: fix outdated ContentsManager testing guidance Fix outdated ContentsManager testing guidance Apr 2, 2026
@Zsailer
Copy link
Copy Markdown
Member

Zsailer commented Apr 2, 2026

@terminalchai It appears this PR was submitted using an agent/AI assistance without closer review by you (a person)—this is evident by the top level comment having improper formatting when originally submitted. I've edited the comment to fix the styling.

While we don't discourage using agents/LLMs to aid in contributing to this repo (I've used them myself!), to protect our maintainers from the burden of reviewing a large volume of work without a human oversight, it's really important to us ask you (as part of our community) do your best to ensure you're reviewing your contributions personally when using these tools before submitting. As we begin to use these tools more, let's target the highest quality PRs—not just the code/documentation we submit, but also the PR comments we write so we have a high quality trail of discussion and history around why changes were made.

All that said, thank you for your contribution here! I appreciate you taking the time here to improve our docs.

@Zsailer Zsailer enabled auto-merge (squash) April 2, 2026 15:39
@terminalchai
Copy link
Copy Markdown
Author

@terminalchai It appears this PR was submitted using an agent/AI assistance without closer review by you (a person)—this is evident by the top level comment having improper formatting when originally submitted. I've edited the comment to fix the styling.

While we don't discourage using agents/LLMs to aid in contributing to this repo (I've used them myself!), to protect our maintainers from the burden of reviewing a large volume of work without a human oversight, it's really important to us ask you (as part of our community) do your best to ensure you're reviewing your contributions personally when using these tools before submitting. As we begin to use these tools more, let's target the highest quality PRs—not just the code/documentation we submit, but also the PR comments we write so we have a high quality trail of discussion and history around why changes were made.

All that said, thank you for your contribution here! I appreciate you taking the time here to improve our docs.

Thanks for the note, and for fixing the formatting. That’s fair feedback, and I appreciate you calling it out. I’ll make sure I review both the changes and the PR text more carefully before submitting future AI-assisted contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'jupyter_server.services.contents.tests'

4 participants