Fix for #1479 : Incorrect usage of i18n format#1500
Merged
vidartf merged 2 commits intojupyter-server:mainfrom Mar 7, 2025
Merged
Fix for #1479 : Incorrect usage of i18n format#1500vidartf merged 2 commits intojupyter-server:mainfrom
vidartf merged 2 commits intojupyter-server:mainfrom
Conversation
kjayan
force-pushed
the
i18n-format-1479
branch
from
e27816c to
59384bc
Compare
astitv-sh
approved these changes
Feb 17, 2025
|
Approving the code changes. Thanks for your effort @kjayan! |
andrii-i
approved these changes
Feb 18, 2025
kjayan
force-pushed
the
i18n-format-1479
branch
from
471bbd0 to
0d932e9
Compare
for more information, see https://pre-commit.ci
vidartf
approved these changes
Mar 7, 2025
Contributor
Author
|
Thanks for the merging the changes @vidartf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue #1479 .
Ran a grep across the files under jupyter_server and found 2 occurrences to fix by adding format().